[c++] Push-down spatial metadata in the MultiscaleImage class from Python to C++
#3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write the coordinate space metadata and spatial encoding version metadata for the `MultiscaleImage` in the C++ layer instead of the Python layer.
johnkerl
approved these changes
Jan 23, 2025
| SPATIAL_ENCODING_VERSION_VAL.c_str(), | ||
| true); | ||
|
|
||
| // Set coordinate space metadata. |
There was a problem hiding this comment.
Suggested change
| // Set coordinate space metadata. | |
| // Set coordinat-space metadata. |
There was a problem hiding this comment.
I don't think coordinate space should be hyphenated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3622 +/- ##
==========================================
+ Coverage 86.26% 86.28% +0.01%
==========================================
Files 55 55
Lines 6378 6378
==========================================
+ Hits 5502 5503 +1
+ Misses 876 875 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: John Kerl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: sc-62102
Changes:
Write the
MultiscaleImagecoordinate-space metadata and spatial-encoding metadata in the C++ layer instead of in Python. This leaves theMultiscaleImageMetadataproperties to be addressed in a future PR.