Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Make region_key a categorical when exporting to SpatialData #3588

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Jan 17, 2025

Issue and/or context: sc-61662

Changes:
SpatialData expects the "region_key" column in the obs dataframe to be a categorical. This makes that change.

@jp-dark jp-dark requested review from johnkerl and ivirshup January 17, 2025 21:38
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (44c84bf) to head (b2d4f62).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3588      +/-   ##
==========================================
+ Coverage   86.27%   86.32%   +0.04%     
==========================================
  Files          55       55              
  Lines        6375     6376       +1     
==========================================
+ Hits         5500     5504       +4     
+ Misses        875      872       -3     
Flag Coverage Δ
python 86.32% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.32% <100.00%> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants