[python/c++] Add C++ SOMACoordinateSpace and use it to push Scene metadata down to C++
#3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
changed the title
SOMACoordinateSpace and use it to pushdown Scene metadata to C++SOMACoordinateSpace and use it to push Scene metadata down to C++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
+ Coverage 86.27% 86.31% +0.03%
==========================================
Files 55 55
Lines 6375 6378 +3
==========================================
+ Hits 5500 5505 +5
+ Misses 875 873 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
XanthosXanthopoulos
approved these changes
Jan 21, 2025
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.15 release-1.15
# Navigate to the new working tree
cd .worktrees/backport-release-1.15
# Create a new branch
git switch --create backport-3580-to-release-1.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 31b66cc9fd89465e2ac6332f58773bb725cfa8b8
# Push it to GitHub
git push --set-upstream origin backport-3580-to-release-1.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.15Then, create a pull request where the |
johnkerl
pushed a commit
that referenced
this pull request
Jan 21, 2025
… metadata down to C++ (#3580) Create a new class `SOMACoordinateSpace` in C++ and use it to read/write coordinate space metadata. Use this class to write coordinate space metadata for the `SOMAScene` class in C++. This replaces writing the metadata in the Python layer and fixes an issue where the `Scene` metadata was being written in a later timestamp than other core metadata like the SOMA datatype.
johnkerl
changed the title
SOMACoordinateSpace and use it to push Scene metadata down to C++SOMACoordinateSpace and use it to push Scene metadata down to C++
johnkerl
added a commit
that referenced
this pull request
Jan 21, 2025
… use it to push `Scene` metadata down to C++ (#3602) * [python/cpp] Add C++ `SOMACoordinateSpace` and use it to push `Scene` metadata down to C++ (#3580) Create a new class `SOMACoordinateSpace` in C++ and use it to read/write coordinate space metadata. Use this class to write coordinate space metadata for the `SOMAScene` class in C++. This replaces writing the metadata in the Python layer and fixes an issue where the `Scene` metadata was being written in a later timestamp than other core metadata like the SOMA datatype. * std::format -> fmt::format for C++17 on release-1.15 branch * fix merge * re-run lint-fixer after merge --------- Co-authored-by: Julia Dark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: sc-62098 and sc-62100
Changes:
Create a new class
SOMACoordinateSpacein C++ and use it to read/write coordinate space metadata. Use this class to write coordinate space metadata for theSOMASceneclass in C++. This replaces writing the metadata in the Python layer and fixes an issue where theScenemetadata was being written in a later timestamp than other core metadata like the SOMA datatype.Notes:
A similar change will be made for writing the metadata for
MultiscaleImageandPointCloudDataFrame, but the Pythoncreatemethod for both of the other classes need other changes first so it will be addressed in future PRs.