Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add the spatial-encoding version to Scene and PointCloudDataFrame objects #3559

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jp-dark
Copy link
Collaborator

@jp-dark jp-dark commented Jan 14, 2025

Issue and/or context: sc-61913

Adds the spatial encoding version to Scene and PointCloudDataFrame objects.

@jp-dark jp-dark requested review from nguyenv and johnkerl January 14, 2025 20:18
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.25%. Comparing base (dc118ee) to head (6094ad8).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3559      +/-   ##
==========================================
+ Coverage   86.20%   86.25%   +0.05%     
==========================================
  Files          55       55              
  Lines        6400     6402       +2     
==========================================
+ Hits         5517     5522       +5     
+ Misses        883      880       -3     
Flag Coverage Δ
python 86.25% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.25% <100.00%> (+0.05%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl changed the title [python] Adds the spatial encoding version to Scene and PointCloudDataFrame objects [python] Add the spatial-encoding version to Scene and PointCloudDataFrame objects Jan 14, 2025
@jp-dark jp-dark merged commit 686f4f4 into main Jan 14, 2025
11 checks passed
@jp-dark jp-dark deleted the dark/sc-61913 branch January 14, 2025 21:03
Copy link

The backport to release-1.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-1.15 release-1.15
# Navigate to the new working tree
cd .worktrees/backport-release-1.15
# Create a new branch
git switch --create backport-3559-to-release-1.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 686f4f4ad6578c3ea1a9e39404e935ba4003a51e
# Push it to GitHub
git push --set-upstream origin backport-3559-to-release-1.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-1.15

Then, create a pull request where the base branch is release-1.15 and the compare/head branch is backport-3559-to-release-1.15.

johnkerl pushed a commit that referenced this pull request Jan 21, 2025
…DataFrame` objects (#3559)

* Add spatial version to `Scene` and `PointCloudDataFrame`
* Add python tests for spatial version number
johnkerl added a commit that referenced this pull request Jan 21, 2025
…DataFrame` objects (#3559) (#3603)

* Add spatial version to `Scene` and `PointCloudDataFrame`
* Add python tests for spatial version number

Co-authored-by: Julia Dark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants