Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests #177

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Fix integration tests #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
01294b5
Fix integration tests
Feb 19, 2024
4428fba
- Fix the bulk integration test failures
Feb 19, 2024
859dfef
- Fix rest discovery test
Feb 19, 2024
6157124
Fix cci integration test failures
Feb 23, 2024
431fb12
- Add new discovered stream
Feb 26, 2024
ba8ce96
refactoring changes
Feb 26, 2024
c014568
- Fix pylint issue
Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tap_salesforce/salesforce/bulk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pylint: disable=protected-access
# pylint: disable=protected-access,use-yield-from
import csv
import json
import sys
Expand Down
2 changes: 1 addition & 1 deletion tap_salesforce/salesforce/rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# pylint: disable=protected-access
# pylint: disable=protected-access,use-yield-from
import singer
import singer.utils as singer_utils
from requests.exceptions import HTTPError
Expand Down
19 changes: 19 additions & 0 deletions tests/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,25 @@ def expected_metadata(self):
'WebStoreBuyerGroup': default,
'WebStoreCatalog': default,
'WebStoreCatalogHistory': incremental_created_date,
# added on 2024/02/19
'Address': default,
'FulfillmentOrderShare': incremental_last_modified,
'FulfillmentOrderLineItemFeed': default,
'FulfillmentOrderItemTax': default,
'FulfillmentOrder': default,
'FulfillmentOrderItemTaxFeed': default,
'FulfillmentOrderLineItem': default,
'FulfillmentOrderItemAdjustment': default,
'FulfillmentOrderItemAdjustmentFeed': default,
'FulfillmentOrderFeed': default,
'OperatingHoursShare': incremental_last_modified,
'Shipment': default,
'ShipmentItemHistory': incremental_created_date,
'ShipmentHistory': incremental_created_date,
'ShipmentShare': incremental_last_modified,
'ShipmentItem': default,
'ShipmentItemFeed': default,
'ShipmentFeed': default
}

def rest_only_streams(self):
Expand Down
36 changes: 29 additions & 7 deletions tests/sfbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,26 @@ def expected_metadata():
'WebStoreBuyerGroup': default,
'WebStoreCatalog': default,
'WebStoreCatalogHistory': incremental_created_date,
}
# added on 2024/02/19
'Address': default,
'FulfillmentOrderShare': incremental_last_modified,
'FulfillmentOrderLineItemFeed': default,
'FulfillmentOrderItemTax': default,
'FulfillmentOrder': default,
'FulfillmentOrderItemTaxFeed': default,
'FulfillmentOrderLineItem': default,
'FulfillmentOrderItemAdjustment': default,
'FulfillmentOrderItemAdjustmentFeed': default,
'FulfillmentOrderFeed': default,
'OperatingHoursShare': incremental_last_modified,
'Shipment': default,
'ShipmentItemHistory': incremental_created_date,
'ShipmentHistory': incremental_created_date,
'ShipmentShare': incremental_last_modified,
'ShipmentItem': default,
'ShipmentItemFeed': default,
'ShipmentFeed': default
}


@staticmethod
Expand Down Expand Up @@ -1005,21 +1024,24 @@ def get_streams_with_data():
'LoginHistory',
'LeadStatus',
'Lead',
'LightningUsageByFlexiPageMetrics',
'FormulaFunctionAllowedType',
'LoginIp',
'LightningUsageByAppTypeMetrics',
'FileSearchActivity',
'FormulaFunctionCategory',
'LightningUsageByBrowserMetrics',
'Folder',
'FormulaFunction',
'MatchingRule',
'LightningUsageByPageMetrics',

# removing form the list has not getting any data
# 'LightningUsageByFlexiPageMetrics',
# 'LightningUsageByAppTypeMetrics',
# 'LightningUsageByBrowserMetrics',
# 'LightningUsageByPageMetrics',
# 'LightningToggleMetrics',
# 'LightningExitByPageMetrics',

'LoginGeo',
'FlowDefinitionView',
'LightningToggleMetrics',
#'LightningExitByPageMetrics', --- removing form the list has not getting any data
'PermissionSetTabSetting',
'MilestoneType',
'Period',
Expand Down
1 change: 1 addition & 0 deletions tests/test_salesforce_discovery_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ def discovery_test(self):
'ApiEvent', 'WorkOrder', 'ContactCleanInfo', 'ResourceAbsence', 'ReturnOrder',
'LegalEntity', 'PaymentMethod', 'EventLogFile', 'ServiceAppointment',
'DandBCompany', 'AccountCleanInfo', 'Organization', 'Document', 'Account',
'Address', 'FulfillmentOrder'
}

# verify that all other fields have inclusion of available
Expand Down