tdl-17121, 24442, 24575 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhtowles
reviewed
Jan 16, 2024
|
|
||
| initial_bookmarks = {} | ||
| streams_replication_method = {} | ||
| def streams_replication_methods(self): |
There was a problem hiding this comment.
Wondering if these two methods are specific to the bookmarks test or should be moved to sfbase
There was a problem hiding this comment.
For now I think its better to leave them in bookmark test, I don't see other test which requires these methods for now.
bhtowles
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Created select by default test , modified bookmark test to new framwork, rework on existing tests to address quota issue.
QA steps
Risks
low
Rollback steps