Allow deleting tons of files on macOS and Windows (#113)

Co-authored-by: Sindre Sorhus <[email protected]>

lib/chunked-exec.js

@@ -0,0 +1,12 @@
+const {promisify} = require('util');
+const {execFile} = require('child_process');
+
+const pExecFile = promisify(execFile);
+
+module.exports = async (binary, paths, maxPaths) => {
+	// TODO: Use https://github.com/sindresorhus/chunkify when targeting Node.js 12.
+	for (let group = 0; paths.length > group; group += maxPaths) {
+		// eslint-disable-next-line no-await-in-loop
+		await pExecFile(binary, paths.slice(group, group + maxPaths));
+	}
+};

lib/macos.js

@@ -1,11 +1,9 @@
 'use strict';
-const {promisify} = require('util');
 const os = require('os');
 const path = require('path');
-const {execFile} = require('child_process');
+const chunkedExec = require('./chunked-exec');
 
 const isOlderThanMountainLion = Number(os.release().split('.')[0]) < 12;
-const pExecFile = promisify(execFile);
 
 // Binary source: https://github.com/sindresorhus/macos-trash
 const binary = path.join(__dirname, 'macos-trash');
@@ -15,5 +13,5 @@ module.exports = async paths => {
 		throw new Error('macOS 10.12 or later required');
 	}
 
-	await pExecFile(binary, paths);
+	await chunkedExec(binary, paths, 1000);
 };

lib/windows.js

@@ -1,13 +1,10 @@
 'use strict';
-const {promisify} = require('util');
 const path = require('path');
-const {execFile} = require('child_process');
-
-const pExecFile = promisify(execFile);
+const chunkedExec = require('./chunked-exec');
 
 // Binary source: https://github.com/sindresorhus/recycle-bin
 const binary = path.join(__dirname, 'windows-trash.exe');
 
 module.exports = async paths => {
-	await pExecFile(binary, paths);
+	await chunkedExec(binary, paths, 200);
 };

test.js

@@ -102,15 +102,15 @@ test('directories', async t => {
 	t.false(fs.existsSync(321));
 });
 
-(process.platform === 'linux' ? test : test.failing)('tons of files', async t => {
+test('tons of files', async t => {
 	const FILE_COUNT = 5000;
 	const paths = [];
 	for (let i = 0; i < FILE_COUNT; i++) {
 		paths.push('file' + i);
 		fs.writeFileSync('file' + i, '');
 	}
 
-	await t.notThrowsAsync(trash(paths));
+	await trash(paths);
 
 	for (let i = 0; i < FILE_COUNT; i++) {
 		t.false(fs.existsSync('file' + i));