Skip to content
/ string-width Public

Handle grapheme contains more than one code points #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Handle grapheme contains more than one code points #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.js
View file
Original file line number Diff line number Diff line change
@@ -40,6 +40,12 @@ export default function stringWidth(string, options = {}) {
continue;
}

// For grapheme contains more than one code points
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. Graphemes can have two code points and still take up a 1 width.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I can see that from test, but not sure what's correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...grapheme].some(codePoint => eastAsianWidth(codePoint ) > 2)?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm honestly not sure. The East Asian Width spec doesn't provide any guidance for that. From what I have seen from other implementations, all others use the first code point too.

if (character.codePointAt(1)) {
width += 2;
continue;
}

width += eastAsianWidth(codePoint, {ambiguousAsWide: !ambiguousIsNarrow});
}