Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade Node.js minimum supported version to 18 #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kocal
Copy link

@Kocal Kocal commented Aug 29, 2024

Hi, this PR upgrades pkg-dir ^7.0 to ^8.0, which reduces the dependencies tree and bandwidth consumption:

Package size report
===================

Package info for "[email protected]": 71 kB
  Released: 2023-08-18 23:47:06.336 +0000 UTC (53w5d ago)
  Downloads last week: 120,595 (0.34%)
  Estimated traffic last week: 8.6 GB
  Subdependencies: 8

Removed dependencies:
  - [email protected]: 59 kB (82.96%)
    Downloads last week: 6,364,454 (N/A% from 7.0.0)
    Downloads last week from "[email protected]": 120,595 (N/A%)
    Traffic last week: N/A
    Traffic from "[email protected]": 8.6 GB (N/A%)
    Subdependencies: 6 (75%)

Added dependencies:
  + [email protected]: 13 kB (18.48%)
    Downloads last week: 38,758 (N/A% from 8.0.0)
    Estimated traffic last week: N/A
    Subdependencies: 1 (12.5%)

Estimated new statistics:
  Package size: 71 kB → 18 kB (24.61%)
  Subdependencies: 8 → 3 (-5)
  Traffic with last week's downloads:
    For current version: 8.6 GB → 2.1 GB (6.5 GB saved)
    For all versions: 2.5 TB → 615 GB (1.9 TB saved)

Before:
image

After:
image

Since pkg-dir@^8.0 requires Node.js 18, we must requires Node.js 18 here too. This update is a breaking change ... or not, depending if dropping a non-maintained version is a BC or not.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant