fix: allow passing WebContents to the window option #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quanglam2807
changed the title
|
Ensure you have manually tested this with the supported typed: |
quanglam2807
commented
Aug 29, 2024
| if (win.once !== undefined) { // Support for BrowserView | ||
| win.webContents.once('destroyed', disposable); | ||
| } | ||
| webContents(win).once('destroyed', disposable); |
There was a problem hiding this comment.
win is not always BrowserWindow, so we must use utils to get WebContents:
electron-context-menu/index.js
Line 7 in 691c307
|
@sindresorhus Thanks for reminding! I've tested it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #184
CC: @lovemegowin @sindresorhus