fix: object has been destroyed

[benoitf]

#182 added some changes in v4.0.2

but in our case, when closing the application there is now an error thrown by the code

A JavaScript error occurred in the main process

Uncaught Exception:
TypeError: Object has been destroyed
at WebContents.disposable (packages/main/dist/index.cjs:11962:12)
at Object.onceWrapper (node:events:634:26)
at WebContents.emit (node:events:519:28)

the related code is:

electron-context-menu/index.js

Line 377 in 125230e

win.webContents.off('destroyed', disposable);

we can't unsubscribe once it's already destroyed

trying to move the unsubscribe outside of the callback itself (I don't know if it was expected to have a self-reference callback)

[benoitf]

To reproduce the issue in your example, use the following code in fixture.js that will destroy the window

(async () => {
	await app.whenReady();

	const window = new BrowserWindow({
		webPreferences: {
			spellcheck: true,
		},
	});

	await window.loadFile(path.join(import.meta.dirname, 'fixture.html'));

	// wait 5seconds, destroy the window
	setTimeout(() => {
		window.destroy();
	}, 5000);
})();

[sindresorhus]

// @lovemegowin

[lovemegowin]

We can remove

electron-context-menu/index.js

Line 377 in 125230e

win.webContents.off('destroyed', disposable);

to quickly fix this error, because we use once.
But it also will cause memory leak in multiple window case.

Could you please do this remove ? @benoitf

[benoitf]

@lovemegowin I've amended the PR

[lovemegowin]

I have reviewed the electron events, but didn't found a reasonable timing to do this cleanup yet.
I tested it use win.close(), the destroyed event will trigger before webContent destroyed, but in win.destroy() this case, the webContent will be destroyed before destroyed event emitted.
Any way， I will do more research about it.

[benoitf]

thanks @sindresorhus for the quick merge and the new release