Fix menu disposal (#180)

sindresorhus · Jun 26, 2024 · 3cfcb4b · 3cfcb4b
1 parent d48f868
commit 3cfcb4b
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/index.js b/index.js
@@ -373,21 +373,14 @@ export default function contextMenu(options = {}) {
 
 		const disposeMenu = create(win, options);
 
-		disposables.push(disposeMenu);
-		const removeDisposable = () => {
-			const index = disposables.indexOf(disposeMenu);
-			if (index !== -1) {
-				disposables.splice(index, 1);
-			}
+		const disposable = () => {
+			win.off('close', disposable);
+			disposeMenu();
 		};
 
 		if (win.once !== undefined) { // Support for BrowserView
-			win.once('closed', removeDisposable);
+			win.once('close', disposable);
 		}
-
-		disposables.push(() => {
-			win.off('closed', removeDisposable);
-		});
 	};
 
 	const dispose = () => {