refactor: deserialize items same as conversation client

sinch · Feb 10, 2025 · 9eed7ac · 9eed7ac
1 parent 549fcd1
commit 9eed7ac
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/tests/Sinch.Tests/Conversation/Messages/ContactMessageTests.cs b/tests/Sinch.Tests/Conversation/Messages/ContactMessageTests.cs
@@ -14,7 +14,7 @@ public void DeserializeChannelSpecificNfmReplyMessage()
             var json = Helpers.LoadResources(
                 "Conversation/Messages/ContactMessage/ContactMessageChannelSpecificContactMessageNfmReply.json");
 
-            var result = JsonSerializer.Deserialize<ContactMessage>(json);
+            var result = DeserializeAsConversationClient<ContactMessage>(json);
 
             result.Should().BeEquivalentTo(new ContactMessage(new ChannelSpecificContactMessage()
             {
@@ -38,7 +38,7 @@ public void DeserializeContactMessageProductResponseMessage()
             var json = Helpers.LoadResources(
                 "Conversation/Messages/ContactMessage/ContactMessageProductResponseMessage.json");
 
-            var result = JsonSerializer.Deserialize<ContactMessage>(json);
+            var result = DeserializeAsConversationClient<ContactMessage>(json);
 
             result.Should().BeEquivalentTo(new ContactMessage(new ProductResponseMessage()
             {
@@ -67,7 +67,7 @@ public void DeserializeContactMessageChoiceMessage()
             var json = Helpers.LoadResources(
                 "Conversation/Messages/ContactMessage/ContactMessageChoiceResponseMessage.json");
 
-            var result = JsonSerializer.Deserialize<ContactMessage>(json);
+            var result = DeserializeAsConversationClient<ContactMessage>(json);
 
             result.Should().BeEquivalentTo(new ContactMessage(new ChoiceResponseMessage()
             {
@@ -84,7 +84,7 @@ public void DeserializeContactMessageFallbackMessage()
         {
             var json = Helpers.LoadResources("Conversation/Messages/ContactMessage/ContactMessageFallbackMessage.json");
 
-            var result = JsonSerializer.Deserialize<ContactMessage>(json);
+            var result = DeserializeAsConversationClient<ContactMessage>(json);
 
             result.Should().BeEquivalentTo(new ContactMessage(new FallbackMessage()
             {
@@ -106,7 +106,7 @@ public void DeserializeContactMessageLocationMessage()
         {
             var json = Helpers.LoadResources("Conversation/Messages/ContactMessage/ContactMessageLocationMessage.json");
 
-            var result = JsonSerializer.Deserialize<ContactMessage>(json);
+            var result = DeserializeAsConversationClient<ContactMessage>(json);
 
             result.Should().BeEquivalentTo(new ContactMessage(new LocationMessage()
             {
@@ -125,7 +125,7 @@ public void DeserializeContactMessageMediaCardMessage()
             var json = Helpers.LoadResources(
                 "Conversation/Messages/ContactMessage/ContactMessageMediaCardMessage.json");
 
-            var result = JsonSerializer.Deserialize<ContactMessage>(json);
+            var result = DeserializeAsConversationClient<ContactMessage>(json);
 
             result.Should().BeEquivalentTo(new ContactMessage(new MediaCardMessage()
             {
@@ -142,7 +142,7 @@ public void DeserializeContactMessageMediaMessage()
         {
             var json = Helpers.LoadResources("Conversation/Messages/ContactMessage/ContactMessageMediaMessage.json");
 
-            var result = JsonSerializer.Deserialize<ContactMessage>(json);
+            var result = DeserializeAsConversationClient<ContactMessage>(json);
 
             result.Should().BeEquivalentTo(new ContactMessage(new MediaMessage()
             {
@@ -160,7 +160,7 @@ public void DeserializeContactMessageTextMessage()
         {
             var json = Helpers.LoadResources("Conversation/Messages/ContactMessage/ContactMessageTextMessage.json");
 
-            var result = JsonSerializer.Deserialize<ContactMessage>(json);
+            var result = DeserializeAsConversationClient<ContactMessage>(json);
 
             result.Should().BeEquivalentTo(new ContactMessage(new TextMessage("This is a text message."))
             {

diff --git a/tests/Sinch.Tests/Conversation/SendMessageTests.cs b/tests/Sinch.Tests/Conversation/SendMessageTests.cs
@@ -519,10 +519,7 @@ public void DeserializeTll(string actual, int? expected)
             // NOTE: api doesn't return TTL for deserialization anywhere
             _baseMessageExpected.ttl = actual;
             var json = JsonConvert.SerializeObject(_baseMessageExpected as object);
-            var result = JsonSerializer.Deserialize<SendMessageRequest>(json, new JsonSerializerOptions()
-            {
-                PropertyNamingPolicy = new SnakeCaseNamingPolicy()
-            });
+            var result = DeserializeAsConversationClient<SendMessageRequest>(json);
             result.TtlSeconds.Should().Be(expected);
         }
     }