Optimize SwooleConfig to open open_mqtt_protocol by default (#52)

* Optimize SwooleConfig to open open_mqtt_protocol by default * remove * Fix code style
simps · May 17, 2021 · 73ac7ac · 73ac7ac
1 parent 3b6843b
commit 73ac7ac
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/src/Config/ClientConfig.php b/src/Config/ClientConfig.php
@@ -19,7 +19,9 @@ class ClientConfig extends AbstractConfig
 {
     protected $clientId = '';
 
-    protected $swooleConfig = [];
+    protected $swooleConfig = [
+        'open_mqtt_protocol' => true,
+    ];
 
     protected $userName = '';
 
@@ -58,7 +60,7 @@ public function getSwooleConfig(): array
 
     public function setSwooleConfig(array $config): self
     {
-        $this->swooleConfig = $config;
+        $this->swooleConfig = array_merge($this->swooleConfig, $config);
 
         return $this;
     }

diff --git a/tests/Unit/ClientConfigTest.php b/tests/Unit/ClientConfigTest.php
@@ -45,4 +45,21 @@ public function testIsMQTT5()
         $this->assertTrue($config->isMQTT5());
         $this->assertEquals($config->getProtocolLevel(), ProtocolInterface::MQTT_PROTOCOL_LEVEL_5_0);
     }
+
+    public function testSwooleDefaultConfig()
+    {
+        $config = new ClientConfig();
+        $config->setSwooleConfig([]);
+        $this->assertEquals($config->getSwooleConfig(), [
+            'open_mqtt_protocol' => true,
+        ]);
+        $config->setSwooleConfig([
+            'open_mqtt_protocol' => false,
+            'package_max_length' => 2 * 1024 * 1024,
+        ]);
+        $this->assertEquals($config->getSwooleConfig(), [
+            'open_mqtt_protocol' => false,
+            'package_max_length' => 2 * 1024 * 1024,
+        ]);
+    }
 }