add simplyblock-storage.yaml file #135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| app: simplyblock-storages | ||
| spec: | ||
| serviceAccountName: storage-node-sa | ||
| nodeSelector: |
There was a problem hiding this comment.
How do you handle for cases of secondary storage node and also node to perform primary node restart? as this two have a separate node label
There was a problem hiding this comment.
The purpose of this folder (deploy/kubernetes) is to provide examples. So of all the 3 storage node type its best to have example for simplyblock-storage-plane and remaining can be re-created from this file by just modifying the app Labels and nodeSelector
There was a problem hiding this comment.
Won't it be best we just created them also in the example?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier for deploying storage nodes individually.