Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PartitionedFile.filePath handling for spark 3.5.0 #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BjoernWaechter
Copy link

@BjoernWaechter BjoernWaechter commented Oct 27, 2023

Fixes #113

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BjoernWaechter BjoernWaechter mentioned this pull request Oct 27, 2023
@@ -36,7 +36,7 @@ lazy val commonIOVersion = "2.5"
lazy val logbackVersion = "1.1.7"
lazy val scoptVersion = "3.7.1"
lazy val akkaVersion = "2.5.31"
lazy val spark3Version = "3.1.1"
lazy val spark3Version = "3.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change break compatibility with Spark 3.2 and 3.1?
At the moment, I can not expend time doing the testing (basically, I'm focused on looking for a new contract. If you know one, let me know. 😉 )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do some testing with spark 3.3, 3.2, 3.1 and will let you know about the result.
If I see an interesting project, I will let you know.

Copy link

@jensgoossens-tomtom jensgoossens-tomtom Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any progress on this? You could keep the version on 3.1.1 and just call toString anyway - for people using Spark 3.4+ it will call toString() on the SparkPath returned - for people using older versions nothing will change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the fix is not working for older versions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to increase the version, and release it for Spark 3.5?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensgoossens-tomtom @alexeisolodovnicov-tomtom Maybe your company is able to support this project. That would give me a little bit of energy and motivation. Even one beer would be enough. ;)

I'm open to any type of collaboration. Are they looking for Solution Architects?

https://github.com/sponsors/simplexspatial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spark 3.5
4 participants