Updated to Socket.IO v1 api in case of active signalmaster's maxClients configuration #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return io.sockets.clients(name).length; | ||
| var room = io.sockets.adapter.rooms[name]; | ||
| if (room && room.length) { | ||
| return room.length; |
There was a problem hiding this comment.
This doesn't work for me:
room.length is always undefined.
You should use Object.keys(room).length instead of room.length
Otherwise clientsInRooms is always 0;
|
My "fix" was indeed wrong. I updated the pr, I also noticed that to get the room, in other functions in signalmaster, the namespace was selected manually, so I went that way also here. Let me know any further problems or requirements Thanks |
ttdollar
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a trivial fix for Socket.IO v1, I encountered the bug using maxClients in the config. I wasn't sure if it's good to return 0 if the
roomis not valid (because I'm not sure how it can happen that is not valid).Let me know if I need to adjust anything.
(Thanks for signalmaster, btw :D)