Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logic to request ice servers into factory class #108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noeplease
Copy link

We would like to remove the functionality use retrieve a local list of ice servers and replace the logic with factory class to allow one to retrieve a list of ice servers from any service.

@noeplease
Copy link
Author

I would like to mentioned the reason for the pull request is to seamlessly apply/incorporate Xirsys as a source for turn and stun servers.
Here's an example of what a third party factory would resemble:
https://github.com/xirdev/signalmaster/blob/xirsysIceFactory/xirsysIceServers.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants