Fastlane #125
Fastlane #125
Conversation
tinypell3ts
requested review from
craigcoles and
benjaminreid
and removed request for
craigcoles
|
@andykitt Can we add some notes to the readme about this also? 🙌 |
| puts "-------------------------------------------------------" | ||
| firebase_app_distribution( | ||
| app: ENV['IOS_APP_ID'], | ||
| ipa_path: "builds/v#{version}/#{appname}.ipa", |
There was a problem hiding this comment.
This path would fail if you didn't run thegithub_release lane first. Needs a re-think.
There was a problem hiding this comment.
I've now added a skip_build option. This means the iOS version will re-build unless you add the skip_build parameter. yarn run firebase:release skip_build:true.
| puts "-------------------------------------------------------" | ||
| firebase_app_distribution( | ||
| app: ENV['ANDROID_APP_ID'], | ||
| apk_path: "android/app/build/outputs/apk/debug/app-debug.apk", |
There was a problem hiding this comment.
This needs to be release not debug.
|
@KateHoward10 Did you manage to have a look at this yesterday? What was the consensus? |
I did indeed. I haven't actually managed to get a release to work yet, but due to the way I've set up a RN project to test it on, rather than the changes in here. Fastlane got installed pretty painlessly 👍 |
* master: 📝 Update references to romulus-cli from previous project codename Remove original issue template Update issue templates Bump version React Query Option (#128) Bump lodash from 4.17.15 to 4.17.19
Proposed changes
This PR adds a Fastlane flag for installing Fastlane on your machine and adds a
fastlanefolder to the project root.The initial setup includes 4 lanes:
test_setup- To ensure Fastlane is setup correct.version_bump- bump the version and commit to a Github repository.github_release- builds aniOSandAndroidversion, creates a release and upload assets.firebase_release- uploads an.ipaand.apkto a chosen firebase project.Notes
There is room to do so much more, however, I feel this is a good starting point. I split out the beta release lane into three separate lanes. This allows you to use them individually depending on your requirements.