Update CLA link (#70)

* Update CLA link Replace Firebase dynamic links with Bitly alternative * update workflows to reference proper repository * bump version * replace onPopInvoked --------- Co-authored-by: Eric Dhom <[email protected]>
simpleclub · Nov 26, 2024 · 83c54ed · 83c54ed
1 parent 3168d87
commit 83c54ed
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/greetings.yml b/.github/workflows/greetings.yml
@@ -17,11 +17,11 @@ jobs:
           You can expect triage from us soon 🙂
           In the meantime, you can try to search for similar issues in our [issue database].
 
-          [issue database]: https://github.com/simpleclub/design_tokens_builder/issues?q=is%3Aissue
+          [issue database]: https://github.com/simpleclub/math_keyboard/issues
         pr-message: |
           Hi 👋🏽 Thank you for opening your first PR with simpleclub/math_keyboard ❤
           
           You can expect a review from us soon ☺️ 
           In the meantime, please check our [contribution guidelines], the PR checklist, and the PR checks.
           
-          [contribution guidelines]: https://github.com/simpleclub/design_tokens_builder/blob/main/CONTRIBUTING.md
+          [contribution guidelines]: https://github.com/simpleclub/math_keyboard/blob/main/CONTRIBUTING.md
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -53,5 +53,5 @@ In order for us to review and merge your code, please follow the link and sign t
 [create pr]: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork
 [GitHub hub]: https://hub.github.com
 [ssh key]: https://help.github.com/articles/generating-ssh-keys
-[CLA]: https://simpleclub.page.link/cla
+[CLA]: https://bit.ly/simpleclub-cla
 [versioning]: https://stackoverflow.com/questions/66201337/how-do-dart-package-versions-work-how-should-i-version-my-flutter-plugins/66201338#66201338
diff --git a/math_keyboard/CHANGELOG.md b/math_keyboard/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.3.1
+
+* Updated README
+
 ## 0.3.0
 
 * Updated all dependencies

diff --git a/math_keyboard/lib/src/widgets/math_field.dart b/math_keyboard/lib/src/widgets/math_field.dart
@@ -483,7 +483,7 @@ class _MathFieldState extends State<MathField> with TickerProviderStateMixin {
   Widget build(BuildContext context) {
     return PopScope(
       canPop: !_isKeyboardShown,
-      onPopInvoked: (didPop) async {
+      onPopInvokedWithResult: (didPop, result) async {
         if (!didPop) {
           _closeKeyboard();
         }

diff --git a/math_keyboard/pubspec.yaml b/math_keyboard/pubspec.yaml
@@ -2,7 +2,7 @@ name: math_keyboard
 description: >-2
   Math expression editing using an on-screen software keyboard or physical keyboard input in a
   typeset input field in Flutter.
-version: 0.3.0
+version: 0.3.1
 homepage: https://github.com/simpleclub/math_keyboard/tree/main/math_keyboard
 
 environment: