fix: spf record verification user_audit_log

simple-login · Oct 16, 2024 · 564ce14 · 564ce14
1 parent 0ec67c7
commit 564ce14
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/custom_domain_validation.py b/app/custom_domain_validation.py
@@ -182,16 +182,16 @@ def validate_spf_records(
         expected_spf_domain = self.get_expected_spf_domain(custom_domain)
         if expected_spf_domain in spf_domains:
             custom_domain.spf_verified = True
-            Session.commit()
-            return DomainValidationResult(success=True, errors=[])
-        else:
-            custom_domain.spf_verified = False
             emit_user_audit_log(
                 user=custom_domain.user,
                 action=UserAuditLogAction.VerifyCustomDomain,
                 message=f"Verified SPF records for custom domain {custom_domain.id} ({custom_domain.domain})",
             )
             Session.commit()
+            return DomainValidationResult(success=True, errors=[])
+        else:
+            custom_domain.spf_verified = False
+            Session.commit()
             txt_records = self._dns_client.get_txt_record(custom_domain.domain)
             cleaned_records = self.__clean_spf_records(txt_records, custom_domain)
             return DomainValidationResult(