Fix failure when setting faillock_log_dir (#123)

This patch fixes a bug that failed when setting faillock_log_dir Fixes #122 Co-authored-by: op-ct <[email protected]>
simp · Apr 14, 2022 · 4e94a1c · 4e94a1c
1 parent bb96087
commit 4e94a1c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,6 @@
+* Wed Apr 13 2022 Mike Riddle <[email protected]> - 6.11.1
+- Fix bug that failed when setting faillock_log_dir parameter
+
 * Mon Mar 28 2022 Mike Riddle <[email protected]> - 6.11.0
 - Add dictcheck parameter to pwquality
 - Add faillock_log_file parameter

diff --git a/manifests/config.pp b/manifests/config.pp
@@ -106,7 +106,7 @@
   }
 
   if ($pam::faillock_log_dir) {
-    file { '$pam::faillock_log_dir':
+    file { $pam::faillock_log_dir:
       ensure   => 'dir',
       owner    => 'root',
       group    => 'root',

diff --git a/metadata.json b/metadata.json
@@ -1,6 +1,6 @@
 {
   "name": "simp-pam",
-  "version": "6.11.0",
+  "version": "6.11.1",
   "author": "SIMP Team",
   "summary": "A SIMP puppet module for managing pam",
   "license": "Apache-2.0",

diff --git a/spec/classes/config_spec.rb b/spec/classes/config_spec.rb
@@ -292,6 +292,11 @@
           }
         end
 
+        context 'with faillock_log_dir set' do
+          let(:params){{ :faillock_log_dir => '/var/log/faillock' }}
+          it { is_expected.to contain_file('/var/log/faillock') }
+        end
+
         context 'no warn_if_unknown = false' do
           let(:params){{ :warn_if_unknown => false }}
           it { is_expected.to contain_file('/etc/pam.d/other').with_content(<<~EOM