Skip to content

Add model_name parameter to OpenAI extra models documentation #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025

Conversation

dguido
Copy link
Contributor

@dguido dguido commented Apr 23, 2025

Summary

  • Fix documentation for extra OpenAI models configuration by adding the required model_name parameter
  • Add explanation about the difference between model_id and model_name
  • model_id is used internally for logging while model_name is passed to the API

Fixes #925

🤖 Generated with Claude Code

Fix documentation for extra OpenAI models configuration by adding the required model_name parameter and explaining the difference between model_id and model_name. Fixes simonw#925.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@simonw
Copy link
Owner

simonw commented May 4, 2025

I landed a change that fixes that here:

@simonw simonw closed this May 4, 2025
@simonw
Copy link
Owner

simonw commented May 4, 2025

... but I"m going to use yours too, I like your explanation of the difference.

@simonw simonw reopened this May 4, 2025
@simonw simonw merged commit 16a58f2 into simonw:main May 4, 2025
1 check passed
@simonw simonw mentioned this pull request May 4, 2025
4 tasks
simonw added a commit that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] required model_name key missing from "Adding more OpenAI models" YAML snippet
2 participants