Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasette package add --config CLI option (#2378) #2379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

king7532
Copy link

@king7532 king7532 commented Aug 3, 2024

See issue #2378.


📚 Documentation preview 📚: https://datasette--2379.org.readthedocs.build/en/2379/

@simonw
Copy link
Owner

simonw commented Aug 15, 2024

A few tests are failing with errors like this:

    def test_publish_cloudrun_extra_options(
        mock_call, mock_output, mock_which, extra_options, expected, tmp_path_factory
    ):
        mock_which.return_value = True
        mock_output.return_value = "myproject"
    
        runner = CliRunner()
        os.chdir(tmp_path_factory.mktemp("runner"))
        with open("test.db", "w") as fp:
            fp.write("data")
        result = runner.invoke(
            cli.cli,
            [
                "publish",
                "cloudrun",
                "test.db",
                "--service",
                "datasette",
                "--show-files",
                "--extra-options",
                extra_options,
            ],
        )
>       assert result.exit_code == 0
E       assert 1 == 0
E        +  where 1 = <Result AttributeError("'str' object has no attribute 'read'")>.exit_code

@king7532
Copy link
Author

@simonw all the failing tests are in tests/test_publish_cloudrun.py and this line is failing for all the tests:

assert result.exit_code == 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants