Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fill totals with correct amount of zeroes for empty reports #2186

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

aragaer
Copy link
Contributor

@aragaer aragaer commented Mar 17, 2024

In current implementation balancesheet and balancesheetequity result in incorrect CSV output if one of the subreports is empty -- the "total" row for that subreport contains only "total" field and nothing else.

The solution is to know in advance the number of columns and fill total with zeroes if subreport is empty.

This might make #588 unneeded since now subreport's totals is never empty.

@aragaer aragaer force-pushed the non-empty-totals branch 4 times, most recently from fc53cec to 0b50885 Compare March 17, 2024 19:51
@simonmichael
Copy link
Owner

Looks good, thank you!

@simonmichael simonmichael merged commit 09e158d into simonmichael:master Mar 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants