imp: Support tsv and ssv prefixes (#2164) #2165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes,
hledger
now supports using thessv:
andtsv:
prefixes to determine the file separator. For example:Some notes from my end:
hledger
, but if this is too wide-reaching a change, it would be straightforward to use something likeRaw String
, which would in turn beRaw "journal"
,Raw "timeclock"
, etc., for everything except the CSV/etc. files.CsvReader.hs
suggest that it should be possible to pass the rules file as an argument and have the data file be inferred. However, I wasn't able to figure out how to do this, either with stockhledger
or with my build. This means I very well might have broken this feature. Could you please share how this is supposed to work so I can verify if it still functions?ssvtest.sh
, which is mostly a copy ofcsvtest.sh
, but I wasn't immediately sure how else to avoid thecsv:.*.csv
pattern used incsvtest.sh
.