Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to vitest 3 #963

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Patch vite-plugin-solid
simonihmig committed Jan 19, 2025
commit a2b0a9d74fa5dddd641297718404cf7175889b65
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -37,6 +37,9 @@
"@ember/test-helpers": "^4.0.4"
}
}
},
"patchedDependencies": {
"[email protected]": "patches/[email protected]"
}
}
}
16 changes: 16 additions & 0 deletions patches/[email protected]
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
diff --git a/dist/esm/index.mjs b/dist/esm/index.mjs
index e065926b3da86406660aba987cb8226af9f0f8fd..bca68dfff42867a904d1be10938240ae459a8612 100644
--- a/dist/esm/index.mjs
+++ b/dist/esm/index.mjs
@@ -102,10 +102,7 @@ function solidPlugin(options = {}) {
include: [...nestedDeps, ...solidPkgsConfig.optimizeDeps.include],
exclude: solidPkgsConfig.optimizeDeps.exclude
},
- ssr: solidPkgsConfig.ssr,
- ...(test.server ? {
- test
- } : {})
+ ssr: solidPkgsConfig.ssr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brenelz this is a patch that's use to allow running vitest 3. Just vanity checking, does this align well with the changes in this PR?

};
},
// @ts-ignore This hook only works in Vite 6
11 changes: 8 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.