Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix error message for non nullable converter #2855

Merged

Conversation

ValentinVignal
Copy link
Contributor

@ValentinVignal ValentinVignal commented Jan 22, 2024

Fixes #2854

Copy link
Owner

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ValentinVignal
Copy link
Contributor Author

I quickly looked around and wasn't able to find if you have already written some tests for reported errors.

Where / how do you want me to write a test for that?

@simolus3
Copy link
Owner

I think this assertion just needs to be expanded to cover the full message:

isDriftError(contains('This column is nullable'))
.withSpan('tc<String?, String>()'),

@ValentinVignal ValentinVignal force-pushed the Fix-nullable-converter-error-message branch from 84e9b36 to b03805d Compare January 22, 2024 11:16
@ValentinVignal
Copy link
Contributor Author

Thank you @simolus3 , I implemented a test in test: Update the tests

@simolus3 simolus3 merged commit 059108f into simolus3:develop Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong message when a non nullable converter is used on a nullable column:
2 participants