Skip to content

Commit

Permalink
Merge pull request #2819 from tt88dev/bugfix/aggregate_test
Browse files Browse the repository at this point in the history 
[bugfix/aggregate_test]
  • Loading branch information
@simolus3
simolus3 authored Jan 3, 2024
2 parents 379b92d + 9dbcdc9 commit 7046f24
Showing 1 changed file with 145 additions and 0 deletions.
145 changes: 145 additions & 0 deletions drift/test/database/expressions/aggregate_test.dart
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ import '../../test_utils/test_utils.dart';

void main() {
const foo = CustomExpression<int>('foo', precedence: Precedence.primary);
const b1 = CustomExpression<BigInt>('b1', precedence: Precedence.primary);
const s1 = CustomExpression<String>('s1', precedence: Precedence.primary);
const p1 = CustomExpression<bool>('p1', precedence: Precedence.primary);

group('count', () {
test('all', () {
Expand All @@ -17,74 +19,157 @@ void main() {
countAll(filter: foo.isBiggerOrEqualValue(3)),
generates('COUNT(*) FILTER (WHERE foo >= ?)', [3]),
);
expect(
countAll(filter: b1.isBiggerOrEqualValue(BigInt.from(3))),
generates('COUNT(*) FILTER (WHERE b1 >= ?)', [BigInt.from(3)]),
);
expect(
countAll(filter: s1.equals('STRING_VALUE')),
generates('COUNT(*) FILTER (WHERE s1 = ?)', ['STRING_VALUE']),
);
expect(
countAll(filter: p1.equals(true)),
generates('COUNT(*) FILTER (WHERE p1 = ?)', [1]),
);
});

test('single', () {
expect(foo.count(), generates('COUNT(foo)'));
expect(b1.count(), generates('COUNT(b1)'));
expect(s1.count(), generates('COUNT(s1)'));
expect(p1.count(), generates('COUNT(p1)'));
});

test('single - distinct', () {
expect(foo.count(distinct: true), generates('COUNT(DISTINCT foo)'));
expect(b1.count(distinct: true), generates('COUNT(DISTINCT b1)'));
expect(s1.count(distinct: true), generates('COUNT(DISTINCT s1)'));
expect(p1.count(distinct: true), generates('COUNT(DISTINCT p1)'));
});

test('single - filter', () {
expect(
foo.count(filter: foo.isBiggerOrEqualValue(3)),
generates('COUNT(foo) FILTER (WHERE foo >= ?)', [3]),
);
expect(
b1.count(filter: b1.isBiggerOrEqualValue(BigInt.from(3))),
generates('COUNT(b1) FILTER (WHERE b1 >= ?)', [BigInt.from(3)]),
);
expect(
s1.count(filter: s1.equals('STRING_VALUE')),
generates('COUNT(s1) FILTER (WHERE s1 = ?)', ['STRING_VALUE']),
);
expect(
p1.count(filter: p1.equals(true)),
generates('COUNT(p1) FILTER (WHERE p1 = ?)', [1]),
);
});

test('single - distinct and filter', () {
expect(
foo.count(distinct: true, filter: foo.isBiggerOrEqualValue(3)),
generates('COUNT(DISTINCT foo) FILTER (WHERE foo >= ?)', [3]),
);
expect(
b1.count(
distinct: true, filter: b1.isBiggerOrEqualValue(BigInt.from(3))),
generates(
'COUNT(DISTINCT b1) FILTER (WHERE b1 >= ?)', [BigInt.from(3)]),
);
expect(
s1.count(distinct: true, filter: s1.equals('STRING_VALUE')),
generates('COUNT(DISTINCT s1) FILTER (WHERE s1 = ?)', ['STRING_VALUE']),
);
expect(
p1.count(distinct: true, filter: p1.equals(true)),
generates('COUNT(DISTINCT p1) FILTER (WHERE p1 = ?)', [1]),
);
});
});

test('avg', () {
expect(foo.avg(), generates('AVG(foo)'));
expect(b1.avg(), generates('AVG(b1)'));

expect(foo.avg(filter: foo.isBiggerOrEqualValue(3)),
generates('AVG(foo) FILTER (WHERE foo >= ?)', [3]));
expect(b1.avg(filter: b1.isBiggerOrEqualValue(BigInt.from(3))),
generates('AVG(b1) FILTER (WHERE b1 >= ?)', [BigInt.from(3)]));
});

test('max', () {
expect(foo.max(), generates('MAX(foo)'));
expect(b1.max(), generates('MAX(b1)'));
expect(s1.max(), generates('MAX(s1)'));
expect(p1.max(), generates('MAX(p1)'));
});

test('min', () {
expect(foo.min(), generates('MIN(foo)'));
expect(b1.min(), generates('MIN(b1)'));
expect(s1.min(), generates('MIN(s1)'));
expect(p1.min(), generates('MIN(p1)'));
});

test('sum', () {
expect(foo.sum(), generates('SUM(foo)'));
expect(b1.sum(), generates('SUM(b1)'));
});

test('total', () {
expect(foo.total(), generates('TOTAL(foo)'));
expect(b1.total(), generates('TOTAL(b1)'));
});

group('group_concat', () {
test('with the default separator', () {
expect(foo.groupConcat(), generates('GROUP_CONCAT(foo)'));
expect(b1.groupConcat(), generates('GROUP_CONCAT(b1)'));
expect(s1.groupConcat(), generates('GROUP_CONCAT(s1)'));
expect(p1.groupConcat(), generates('GROUP_CONCAT(p1)'));

expect(foo.groupConcat(separator: ','), generates('GROUP_CONCAT(foo)'));
expect(b1.groupConcat(separator: ','), generates('GROUP_CONCAT(b1)'));
expect(s1.groupConcat(separator: ','), generates('GROUP_CONCAT(s1)'));
expect(p1.groupConcat(separator: ','), generates('GROUP_CONCAT(p1)'));
});

test('with a custom separator', () {
expect(foo.groupConcat(separator: ' and '),
generates('GROUP_CONCAT(foo, ?)', [' and ']));
expect(b1.groupConcat(separator: ' and '),
generates('GROUP_CONCAT(b1, ?)', [' and ']));
expect(s1.groupConcat(separator: ' and '),
generates('GROUP_CONCAT(s1, ?)', [' and ']));
expect(p1.groupConcat(separator: ' and '),
generates('GROUP_CONCAT(p1, ?)', [' and ']));
});

test('with a filter', () {
expect(foo.groupConcat(filter: foo.isSmallerThan(const Variable(3))),
generates('GROUP_CONCAT(foo) FILTER (WHERE foo < ?)', [3]));
expect(
b1.groupConcat(filter: b1.isSmallerThan(Variable(BigInt.from(3)))),
generates(
'GROUP_CONCAT(b1) FILTER (WHERE b1 < ?)', [BigInt.from(3)]));
expect(
s1.groupConcat(filter: s1.isSmallerThan(Variable('STRING_VALUE'))),
generates(
'GROUP_CONCAT(s1) FILTER (WHERE s1 < ?)', ['STRING_VALUE']));
expect(p1.groupConcat(filter: p1.equals(true)),
generates('GROUP_CONCAT(p1) FILTER (WHERE p1 = ?)', [1]));
});

test('with distinct', () {
expect(foo.groupConcat(distinct: true),
generates('GROUP_CONCAT(DISTINCT foo)', isEmpty));
expect(b1.groupConcat(distinct: true),
generates('GROUP_CONCAT(DISTINCT b1)', isEmpty));
expect(s1.groupConcat(distinct: true),
generates('GROUP_CONCAT(DISTINCT s1)', isEmpty));
expect(p1.groupConcat(distinct: true),
generates('GROUP_CONCAT(DISTINCT p1)', isEmpty));

expect(
foo.groupConcat(
Expand All @@ -96,11 +181,47 @@ void main() {
[3],
),
);
expect(
b1.groupConcat(
distinct: true,
filter: b1.isSmallerThan(Variable(BigInt.from(3))),
),
generates(
'GROUP_CONCAT(DISTINCT b1) FILTER (WHERE b1 < ?)',
[BigInt.from(3)],
),
);
expect(
s1.groupConcat(
distinct: true,
filter: s1.isSmallerThan(Variable('STRING_VALUE')),
),
generates(
'GROUP_CONCAT(DISTINCT s1) FILTER (WHERE s1 < ?)',
['STRING_VALUE'],
),
);
expect(
p1.groupConcat(
distinct: true,
filter: p1.equals(true),
),
generates(
'GROUP_CONCAT(DISTINCT p1) FILTER (WHERE p1 = ?)',
[1],
),
);
});

test('does not allow distinct with a custom separator', () {
expect(() => foo.groupConcat(distinct: true, separator: ' and '),
throwsArgumentError);
expect(() => b1.groupConcat(distinct: true, separator: ' and '),
throwsArgumentError);
expect(() => s1.groupConcat(distinct: true, separator: ' and '),
throwsArgumentError);
expect(() => p1.groupConcat(distinct: true, separator: ' and '),
throwsArgumentError);

expect(
() => foo.groupConcat(
Expand All @@ -110,6 +231,30 @@ void main() {
),
throwsArgumentError,
);
expect(
() => b1.groupConcat(
distinct: true,
separator: ' and ',
filter: b1.isSmallerThan(Variable(BigInt.from(3))),
),
throwsArgumentError,
);
expect(
() => s1.groupConcat(
distinct: true,
separator: ' and ',
filter: s1.isSmallerThan(Variable('STRING_VALUE')),
),
throwsArgumentError,
);
expect(
() => p1.groupConcat(
distinct: true,
separator: ' and ',
filter: p1.equals(true),
),
throwsArgumentError,
);
});
});
}

0 comments on commit 7046f24

Please sign in to comment.