Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: language default fonts #330

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

cblanken
Copy link

The default font "NotoSans JP" does not render some diacritics very well, in particular, the háček used in several Slavic languages and the acute accent in Greek. The effected languages: Croatian, Czech, Greek, Macedonian, and Slovenian have all been transferred to the "OpenSans" default font group which renders the mentioned diacritics properly.

Font Comparison

NotoSans JP OpenSans
croatian_noto_jp croatian_open_sans
czech_noto_jp czech_open_sans
greek_noto_jp greek_open_sans
macedonian_noto_jp macedonian_open_sans
slovenian_noto_jp slovenian_open_sans

The default font "NotoSans JP" does not render some diacritics very well, in
particular, the háček used in several Slavic languages and the acute accent in Greek.
The effected languages: Croatian, Czech, Greek, Macedonian, and Slovenian have all been
transfered the "OpenSans" default font group which renders the mentioned diacritics
properly.
@simjanos-dev
Copy link
Owner

Wow, thank you so much! Ill check and merge this in tomorrow.

Did you check every language? Im asking because I already have a github issue for it, and if you did, Ill close it.

@cblanken
Copy link
Author

All the languages except the ones that require the additional install step. Also Russian which seemed fine. So it's possible Turkish and/or Thai might have issues, but I couldn't actually install Turkish to check in the dev environment. It would just give this error message.
image

@simjanos-dev
Copy link
Owner

Ill check this out too.

@simjanos-dev
Copy link
Owner

I checked out Turkish, and turns out it is not working: #332

@simjanos-dev
Copy link
Owner

I checked Ukrainian, it is also fine. I'll check Turkish after it's fixed. I'm 99% sure I checked Thai when I added it, and it is being displayed correctly. I'll close #260.

Thank you so much for this, I really appreciate it!

@simjanos-dev simjanos-dev merged commit 9215ad2 into simjanos-dev:dev Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants