-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add_UTF16_support + fix/test array OutOfIndex error #25
Merged
Merged
Changes from 16 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8f411c2
added loadblock fx
Nick-Nuon 6140ff1
first test with generics working
Nick-Nuon d06ae9a
Rewrite tests + first test pass
Nick-Nuon 42f61da
CompleteDecodeBase64CasesUTF16 pass
Nick-Nuon 00c67e2
MoreDecodeTestsUTF16 pass
Nick-Nuon 32f963c
RoundtripBase64UTF16 pass
Nick-Nuon d46697c
slight reorganization
Nick-Nuon 589d82b
BadPaddingBase64UTF16 pass
Nick-Nuon c64f771
DoomedBase64RoundtripUTF16 pass
Nick-Nuon 4ba062a
Truncated doom pass
Nick-Nuon b02a10e
RoundTrip pass
Nick-Nuon bc8fc3e
AbortedSafeRoundtripBase64UTF16 Pass
Nick-Nuon 0f13a6e
All tests pass
Nick-Nuon 75810d9
Added benchmarks + some cleanup
Nick-Nuon 1b817ca
further cleanup
Nick-Nuon e1f2be3
cleanup
Nick-Nuon 3b1979f
Merge remote-tracking branch 'origin/main' into add_UTF16_support
Nick-Nuon f534d0b
Issue511 test pass?
Nick-Nuon 318e3cf
added TruncatedCharErrorUTF16 test
Nick-Nuon 398645f
TruncatedCharErrorScalarUTF16 pass
Nick-Nuon 7ad3374
TruncatedCharErrorUTF16SSE pass
Nick-Nuon b771224
Remove alloc on benchmarks + extrachecks on DecodeUrlSSE
Nick-Nuon d25489f
cleanup
Nick-Nuon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect
ToCharArray
is allocating. I suggest trying...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or possibly...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it:
The benchmarks show an improvement with using s.AsSpan() :
Eg Before:
After: