feat(status_bar): Make status bar style configurable

silviolleite · May 30, 2020 · 8e39aeb · 8e39aeb
1 parent 43a8131
commit 8e39aeb
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -54,6 +54,7 @@ PWA_APP_DISPLAY = 'standalone'
 PWA_APP_SCOPE = '/'
 PWA_APP_ORIENTATION = 'any'
 PWA_APP_START_URL = '/'
+PWA_APP_STATUS_BAR_COLOR = 'default'
 PWA_APP_ICONS = [
     {
         'src': '/static/images/my_app_icon.png',

diff --git a/pwa/app_settings.py b/pwa/app_settings.py
@@ -27,6 +27,7 @@
 PWA_APP_ORIENTATION = getattr(settings, 'PWA_APP_ORIENTATION', 'any')
 PWA_APP_START_URL = resolve_url(getattr(settings, 'PWA_APP_START_URL', _PWA_SCRIPT_PREFIX))
 PWA_APP_FETCH_URL = resolve_url(getattr(settings, 'PWA_APP_FETCH_URL', _PWA_SCRIPT_PREFIX))
+PWA_APP_STATUS_BAR_COLOR = getattr(settings, 'PWA_APP_STATUS_BAR_COLOR', 'default')
 PWA_APP_ICONS = getattr(settings, 'PWA_APP_ICONS', [
     {
         'src': '/static/images/icons/icon-72x72.png',

diff --git a/pwa/templates/manifest.json b/pwa/templates/manifest.json
@@ -9,6 +9,7 @@
   "orientation": {{ PWA_APP_ORIENTATION|js }},
   "background_color": {{ PWA_APP_BACKGROUND_COLOR|js }},
   "theme_color": {{ PWA_APP_THEME_COLOR|js }},
+  "status_bar": {{ PWA_APP_STATUS_BAR_COLOR|js }},
   "icons": {{ PWA_APP_ICONS|js }},
   "dir": {{ PWA_APP_DIR|js }},
   "lang": {{ PWA_APP_LANG|js }}

diff --git a/pwa/templates/pwa.html b/pwa/templates/pwa.html
@@ -12,7 +12,7 @@
 <!-- Add to homescreen for Safari on iOS -->
 <meta name="apple-mobile-web-app-capable" content="yes">
 <meta name="apple-mobile-web-app-title" content="{{ PWA_APP_NAME }}">
-<meta name="apple-mobile-web-app-status-bar-style" content="default">
+<meta name="apple-mobile-web-app-status-bar-style" content="{{ PWA_APP_STATUS_BAR_COLOR }}">
 
 {% if PWA_APP_ICONS_APPLE %}
     {% for icon in PWA_APP_ICONS_APPLE %}

diff --git a/tests/test_settings_attr.py b/tests/test_settings_attr.py
@@ -19,7 +19,8 @@ def test_has_defined(self):
             'PWA_APP_FETCH_URL',
             'PWA_APP_ICONS',
             'PWA_APP_DIR',
-            'PWA_APP_LANG'
+            'PWA_APP_LANG',
+            'PWA_APP_STATUS_BAR_COLOR'
         ]
         for attr in attributes:
             with self.subTest():

diff --git a/tests/test_view.py b/tests/test_view.py
@@ -37,7 +37,8 @@ def test_manifest_contains(self):
             '"orientation":',
             '"icons":',
             '"dir":',
-            '"lang":'
+            '"lang":',
+            '"status_bar":'
         ]
         for expected in contents:
             with self.subTest():