-
Notifications
You must be signed in to change notification settings - Fork 196
add confirmation message when delete is clicked #395
base: master
Are you sure you want to change the base?
Conversation
would love to see this merged cuz... agreed. no confirmation is a bit dangerous. |
+1 |
hey. so, I got @Whiterid's code built using npm/node installed locally on an x86_64 ubuntu 18.04 machine and was running it successfully off a mounted exfat drive. I've never built something in node before so it was a bit of a trick to figure out how to get all the dependencies installed on my machine, but it wasn't too hard to figure out. I used that build to create a new docker imags no problem I then got a raspi 4B+ (armv7) and copied the resulting repo ( For anyone else coming by... you can avoid building by pulling my docker images, here are the resulting paths I pushed to: thank you so much @Whiterid !!! |
also, despite the EDIT: looks like the perpetual loading screen was due to Safari issues, like #340 #248 perhaps. Avoided by using full IP instead of local domain name. I just got droppy built on the pi zero (incredibly there was enough memory), and can now confirm that all three flavors of this PR are functional and accessible (through firefox)!!! The |
@silverwind pinging you because this adds value to the project and the delete button is really scarry. |
Hi @mathematicalmichael ! I can't pull your docker image. I got this message: i'm on linux debian 9. Ty for your response. And ty to your job too. |
@Whiterid oh that's my bad all props belongs to you for doing this PR. I just made sure it built cross-platform. |
@mathematicalmichael you rocks ! |
@silverwind any thoughts about the confirmation for delete option?? |
Please add this function. Without it's way to dangerous to use droppy on a prod system. |
Issue:
Delete button is really dangerous #391