Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly use X-Status #440

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Properly use X-Status #440

merged 1 commit into from
Feb 19, 2024

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Feb 19, 2024

Replaces #438

Follow up of
silverstripe/silverstripe-admin#1640 (review)

Issues

silverstripe/silverstripe-framework#11105
silverstripe/silverstripe-admin#1639

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@lekoala lekoala mentioned this pull request Feb 19, 2024
8 tasks
@lekoala lekoala changed the title use rawurlencode Properly use X-Status Feb 19, 2024
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this!
I'll correct the commit message in a squash-and-merge this time around.

@GuySartorelli GuySartorelli merged commit 11d24ae into silverstripe:2.1 Feb 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants