BUG: Protect against URLsToProcess being falsy #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
requested changes
Oct 6, 2022
GuySartorelli
force-pushed
the
typecastUrlsToArray
branch
from
8767df3
to
2730dce
Compare
GuySartorelli
force-pushed
the
typecastUrlsToArray
branch
from
2730dce
to
3f93eb8
Compare
|
The only change I've made is resolving a linting issue |
|
@chrispenny You've been doing a lot of looking into this module recently and I'm not very familiar with it. This PR looks okay but can you please give it a quick glance and let me know if there's anything obviously problematic about this change? |
|
Sorry team, I've been away on annual leave. The title of the PR makes it sound like we're going to make sure |
GuySartorelli
approved these changes
Sep 21, 2023
GuySartorelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If URLsToProcess is null then a error will be thrown when trying to create a Delete cache job because array_keys expects an array.
[Emergency] Uncaught TypeError: array_keys(): Argument
#1($array) must be of type array, null givenPOST /admin/queuedjobs/Symbiote-QueuedJobs-DataObjects-QueuedJobDescriptor/EditForm
Line 107 in /var/www/stats/vendor/silverstripe/staticpublishqueue/src/Job.ph