Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove TODO comments #92

Merged
merged 1 commit into from
Oct 19, 2023
Merged

MNT Remove TODO comments #92

merged 1 commit into from
Oct 19, 2023

Conversation

sabina-talipova
Copy link
Contributor

sabina-talipova
sabina-talipova commented Oct 10, 2023
View reviewed changes
client/src/bundles/segment-field.js
// preview = this.getEllipsis()
// + value.substr(value.length - this.getMaxPreviewLength(), value.length);
// }

Copy link
Contributor Author

@sabina-talipova sabina-talipova Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented out block exists since 2017th and we didn't uncomment it. I think we don't need this anymore.

@sabina-talipova sabina-talipova mentioned this pull request Oct 11, 2023
Closed
GuySartorelli
GuySartorelli approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 79293f8 into silverstripe:3.1 Oct 19, 2023
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.1/remove-todo branch October 19, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli