Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Remove unused apollo dependency #309

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 30, 2024

Issue silverstripe/silverstripe-admin#1799

GraphQL is unused in Linkfield V4, so there is no need for apollo

Note: unlike other PRs on the parent issue which target CMS 6, this one targets CMS 5.2

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit dcc43fa into silverstripe:4.0 Sep 2, 2024
16 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4.0/remove-apollo branch September 2, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants