Revert injector type hint to Injector #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah — I guess this is is an important point: SilverStripe expects more than a PSR-11 object in place in order to function. It's both a DI container (get) and a generic factory (create). |
|
What suddenly is going on with travis?
|
|
Simon E added that, check recently merged PRs |
|
Oh no, what have I done. I may revert that PR. I should have inspected the output in more detail. |
|
#6950 to fix |
|
You don't like the more verbose output, then? |
|
I would if it were print on error only lol |
|
Or at least error-or-slow. I wonder if it can be configured? |
|
According to @Firesphere there is an open issue to get that resolved, but it's not yet possible. |
sminnee
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues across the framework where
Injector::inst()-create()doesn't resolve to anything.