Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Deprecate Controller::has_curr() #11614

Merged
merged 1 commit into from
Feb 13, 2025
Merged

API Deprecate Controller::has_curr() #11614

merged 1 commit into from
Feb 13, 2025

Conversation

emteknetnz
Copy link
Member

Issue #11386

@emteknetnz emteknetnz mentioned this pull request Feb 13, 2025
Closed
2 tasks
@emteknetnz emteknetnz marked this pull request as ready for review February 13, 2025 03:06
GuySartorelli
GuySartorelli approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible

@GuySartorelli GuySartorelli merged commit db86f83 into silverstripe:5 Feb 13, 2025
19 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/depr-ctrl-curr branch February 13, 2025 20:38
@GuySartorelli GuySartorelli mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli