FIX Loop over current scope when no argument passed to loop block #11251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
May 17, 2024
There was a problem hiding this comment.
This file has not been manually edited. The comments were already in the .peg file and were likely manually removed from this file at some stage.
GuySartorelli
commented
May 17, 2024
| } | ||
|
|
||
| //loop without arguments loops on the current scope | ||
| if ($res['ArgumentCount'] == 0) { | ||
| $on = '$scope->obj(\'Up\', null)->obj(\'Foo\', null)'; | ||
| $on = '$scope->locally()->obj(\'Me\', null, true)'; |
There was a problem hiding this comment.
This is identical to what it renders out if you do a <% loop $Me %>
sabina-talipova
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes a feature that was sitting there in a broken state for a while - looping through the current item in scope.
This is kinda a mix between a fix and a new feature - I'm calling it a fix in the commit because the current state is simply broken, but I'm targeting
5because if someone somehow has a<% loop %>sitting in a template right now (which will be silently failing) they'll get unexpected results after pulling this into their project.Issue