Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Strongly type Fieldlist #11235

Merged
merged 1 commit into from
May 16, 2024
Merged

API Strongly type Fieldlist #11235

merged 1 commit into from
May 16, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 13, 2024 •
edited
Loading

Issue #11198

@emteknetnz emteknetnz marked this pull request as draft May 13, 2024 05:07
@emteknetnz emteknetnz mentioned this pull request May 13, 2024
Closed
@emteknetnz emteknetnz marked this pull request as ready for review May 13, 2024 05:41
@emteknetnz emteknetnz force-pushed the pulls/6/fieldlist-strongly-type branch 6 times, most recently from d538902 to cef6ba8 Compare May 13, 2024 06:49
GuySartorelli
GuySartorelli requested changes May 13, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

insertBefore() and insertAfter() return a bool sometimes - but should return null in those cases instead to be more like other methods in this class.

@emteknetnz emteknetnz force-pushed the pulls/6/fieldlist-strongly-type branch 3 times, most recently from 4b99563 to 8b6bb67 Compare May 14, 2024 04:50
GuySartorelli
GuySartorelli requested changes May 14, 2024
View reviewed changes
@emteknetnz emteknetnz force-pushed the pulls/6/fieldlist-strongly-type branch 2 times, most recently from 4d88bde to 68adc84 Compare May 15, 2024 00:17
GuySartorelli
GuySartorelli requested changes May 15, 2024
View reviewed changes
@emteknetnz emteknetnz force-pushed the pulls/6/fieldlist-strongly-type branch from 68adc84 to ce66dd8 Compare May 15, 2024 02:59
@emteknetnz emteknetnz force-pushed the pulls/6/fieldlist-strongly-type branch from ce66dd8 to 5e04225 Compare May 15, 2024 04:25
GuySartorelli
GuySartorelli requested changes May 16, 2024
View reviewed changes
@emteknetnz emteknetnz mentioned this pull request May 16, 2024
Closed
@emteknetnz emteknetnz force-pushed the pulls/6/fieldlist-strongly-type branch from 5e04225 to a504477 Compare May 16, 2024 04:15
@emteknetnz emteknetnz force-pushed the pulls/6/fieldlist-strongly-type branch from a504477 to 7b847f8 Compare May 16, 2024 06:16
GuySartorelli
GuySartorelli approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - looks like some changes to castedCopy() were made since my last review, in the future please make sure you point out changes that happen after a review that aren't related to that review. I could have missed those, and if there were problems with them I might not have noticed the problems.

In this case the changes look good.

@GuySartorelli GuySartorelli merged commit 3b1d859 into silverstripe:6 May 16, 2024
15 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/fieldlist-strongly-type branch May 16, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli