API Update method signature to match parent class #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
changed the title
GuySartorelli
commented
Oct 14, 2024
| @@ -31,8 +26,3 @@ | |||
| 'sitetree_link', | |||
| [SiteTree::class, 'link_shortcode_handler'] | |||
| ); | |||
|
|
|||
| CMSMenu::remove_menu_class(CMSMain::class); | |||
There was a problem hiding this comment.
Note that CMSMain itself is a special case and should not get ignore_menuitem set to true.
7 tasks
GuySartorelli
commented
Oct 16, 2024
Comment on lines
-3
to
-7
| use SilverStripe\Admin\CMSMenu; | ||
| use SilverStripe\CMS\Controllers\CMSMain; | ||
| use SilverStripe\CMS\Controllers\CMSPageAddController; | ||
| use SilverStripe\CMS\Controllers\CMSPageEditController; | ||
| use SilverStripe\CMS\Controllers\CMSPageSettingsController; |
There was a problem hiding this comment.
None of these are used anymore
emteknetnz
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits:
Commit 1:
Quick tidyup to use the
ignore_menuitemconfiguration property instead of removing the menu items at runtime.Commit 2:
Reflects changes in silverstripe/silverstripe-admin#1836
Issue
admin/*routing logic fromLeftAndMaininto its own abstract class silverstripe-admin#1761