ENH Use standardised BackURL instead of non-standard returnURL #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
force-pushed
the
pulls/6/backurl-not-returnurl
branch
from
1e89412
to
1d67b04
Compare
GuySartorelli
force-pushed
the
pulls/6/backurl-not-returnurl
branch
2 times, most recently
from
59c547f
to
a9ed7b9
Compare
GuySartorelli
force-pushed
the
pulls/6/backurl-not-returnurl
branch
from
a9ed7b9
to
2bea868
Compare
|
Almost certainly intermittent given it hasn't run the tests. Rerunning. |
|
It's still failing, but the failure is in "install additional requirements"
There's no way the change in this PR could have affected that - must be unrelated. I recommend we merge and clean up the CI afterward. |
emteknetnz
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects changes in silverstripe/silverstripe-framework#11353
Issue