Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop duplicated call #2870

Merged
merged 1 commit into from
Aug 2, 2023
Merged

drop duplicated call #2870

merged 1 commit into from
Aug 2, 2023

Conversation

lekoala
Copy link
Contributor

@lekoala lekoala commented Jul 28, 2023

fixes #2869

already called due to init being called in the extension by leftandmain

already called due to init being called in the extension by leftandmain
@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 1, 2023

already called due to init being called in the extension by leftandmain

Can you please just explain that a little clearer? I'm not sure what extension this refers to, nor why calling init would result in this already being called - since this is in init? Are you saying that this line exists somewhere else as well? I don't understand.

@lekoala
Copy link
Contributor Author

lekoala commented Aug 2, 2023

i have explained it here #2869

@GuySartorelli
Copy link
Member

Ahh, sorry, I didn't notice the link to the issue 😅

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Didn't know that extension even existed but it's applied directly to LeftAndMain so this seems sensible

@GuySartorelli GuySartorelli merged commit 78452fc into silverstripe:5 Aug 2, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LeftAndMainPageIconsExtension::generatePageIconsCss is called twice
2 participants