ENH Improve typing to support refactored template layer #647
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
23 tasks
GuySartorelli
force-pushed
the
pulls/3/refactor-template-layer
branch
2 times, most recently
from
d287e85
to
166cd9f
Compare
GuySartorelli
force-pushed
the
pulls/3/refactor-template-layer
branch
3 times, most recently
from
35782de
to
070f521
Compare
GuySartorelli
commented
Oct 10, 2024
Comment on lines
+241
to
+243
| $key = SSTemplateEngine::config()->get('global_key'); | ||
| $engine = SSTemplateEngine::create(); | ||
| $globalKey = md5($engine->renderString($key, ViewLayerData::create([]))); |
There was a problem hiding this comment.
Explicitly use SSTemplateEngine instead of getting whatever's registered against TemplateEngine because this config is specific to SSTemplateEngine and is explicitly ss template syntax.
GuySartorelli
commented
Oct 10, 2024
Comment on lines
-1325
to
1333
| * | ||
| * @return string | ||
| */ | ||
| public function getTag() | ||
| public function getTag(): string | ||
| { | ||
| $template = $this->File->getFrontendTemplate(); | ||
| if (empty($template)) { | ||
| return ''; | ||
| } | ||
| return (string)$this->renderWith($template); | ||
| return $this->renderWith($template); | ||
| } |
There was a problem hiding this comment.
Just adding a bit of type safety since this method gets used in forTemplate() above.
GuySartorelli
force-pushed
the
pulls/3/refactor-template-layer
branch
from
070f521
to
313c34c
Compare
GuySartorelli
commented
Oct 23, 2024
| $next = $record->dbObject($field)->getValue(); | ||
| $next = $record->dbObject($field)?->getValue(); |
There was a problem hiding this comment.
dbObject() can return null
emteknetnz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue