Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Update JS dependencies #1645

Merged

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jan 8, 2024

Description

Update JS dependencies and rebuild tinymce skin (since the tinymce dep was updated).
Supercedes #1644 which was failing CI

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • tests aren't necessary for this change
  • No docs need to be updated
  • CI is green

@GuySartorelli GuySartorelli marked this pull request as draft January 8, 2024 02:56
@GuySartorelli
Copy link
Member Author

Jest tests fail when I try to build so need to look into that a bit - that's probably what was causing the CI to fail in the automated PR.

@GuySartorelli
Copy link
Member Author

Seems to be caused by https://github.com/JedWatson/react-select/releases/tag/react-select%405.8.0 - but there's more to it than just that. It seems like I should be able to just swap aria-context for aria-focused in the test.... except there seems to never be any text inside the aria-focused element. This seems to be the case when running it in the browser as well, so it's not just a jest wonkiness issue.

Also rebuild tinymce skin
@GuySartorelli GuySartorelli force-pushed the pulls/2/update-js-deps branch from f5dc31e to b342f27 Compare January 8, 2024 20:07
@GuySartorelli
Copy link
Member Author

I've opted to remove the tests that were testing the focus message - that's not functionality we control, it's part of the react-select library, so it doesn't make sense for us to be testing that anyway.

@GuySartorelli GuySartorelli marked this pull request as ready for review January 8, 2024 20:38
@emteknetnz emteknetnz merged commit 45a4197 into silverstripe:2 Jan 8, 2024
12 checks passed
@emteknetnz emteknetnz deleted the pulls/2/update-js-deps branch January 8, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants