Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Publish developer-docs before other modules #257

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 20, 2024

Issue #253

Tested locally by creating a new fake release with DEV_MODE=1 in my .env file and adding echo("$name\n");return; to PublishRelease::releaseLibrary() to show the order that modules would be released in

Before:

silverstripe/assets
silverstripe/config
silverstripe/framework
...
silverstripe/developer-docs
...
silverstripe/recipe-kitchen-sink

After:

silverstripe/developer-docs
silverstripe/assets
silverstripe/config
silverstripe/framework
...
silverstripe/recipe-kitchen-sink

I've double checked that silverstripe/developer-docs only appears once in the "after" list

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it should work just fine 👍

@GuySartorelli GuySartorelli merged commit 6801d3c into silverstripe:master May 20, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/master/docs-first branch May 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants