fix ocpsoft#258

silvafabio · Jan 28, 2018 · c375d45 · c375d45
1 parent b779516
commit c375d45
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/addressbuilder/src/main/java/org/ocpsoft/urlbuilder/util/Decoder.java b/addressbuilder/src/main/java/org/ocpsoft/urlbuilder/util/Decoder.java
@@ -17,19 +17,17 @@ public static String query(final CharSequence query)
       return decode(query, true);
    }
 
-   public static String decode(final CharSequence path, final boolean query)
-   {
-
+   public static String decode(final CharSequence path, final boolean query) {
       StringBuilder decoded = new StringBuilder();
       int length = path.length();
       int pos = 0;
 
       while (pos < length) {
-
          // '+' -> ' ' for query strings
          if (query && path.charAt(pos) == '+') {
             decoded.append(' ');
             pos++;
+            continue;
          }
 
          // percent-encoded values
@@ -68,19 +66,14 @@ public static String decode(final CharSequence path, final boolean query)
             else {
                decoded.append('\uFFFD');
             }
-
          }
 
          // not escaped
          else {
             decoded.append(path.charAt(pos));
             pos++;
          }
-
       }
-
       return decoded.toString();
-
    }
-
 }
diff --git a/addressbuilder/src/test/java/org/ocpsoft/urlbuilder/util/DecoderTest.java b/addressbuilder/src/test/java/org/ocpsoft/urlbuilder/util/DecoderTest.java
@@ -28,6 +28,14 @@ public void pathNotEncoded()
       assertEquals("/foobar", Decoder.path("/foobar"));
    }
 
+   @Test
+   public void queryEndingWithSpaceDecoding()
+   {
+      assertEquals("foo ", Decoder.decode("foo%20", true));
+      assertEquals("foo ", Decoder.decode("foo ", true));
+      assertEquals("foo ", Decoder.decode("foo+", true));
+   }
+
    @Test
    public void pathSpaceDecoding()
    {