Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code from NmtModelFactory #69

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Remove obsolete code from NmtModelFactory #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions machine/jobs/huggingface/hugging_face_nmt_model_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,7 @@ def create_model_trainer(self, corpus: ParallelTextCorpus) -> Trainer:
add_unk_trg_tokens=self._config.huggingface.tokenizer.add_unk_trg_tokens,
)

def create_engine(self, half_previous_batch_size=False) -> TranslationEngine:
if half_previous_batch_size:
self._config.huggingface.generate_params.batch_size = max(
self._config.huggingface.generate_params.batch_size // 2, 1
)
def create_engine(self) -> TranslationEngine:
return HuggingFaceNmtEngine(
self._model,
src_lang=self._config.src_lang,
Expand Down
2 changes: 1 addition & 1 deletion machine/jobs/nmt_model_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def create_model_trainer(self, corpus: ParallelTextCorpus) -> Trainer:
...

@abstractmethod
def create_engine(self, half_previous_batch_size=False) -> TranslationEngine:
def create_engine(self) -> TranslationEngine:
...

@abstractmethod
Expand Down
1 change: 0 additions & 1 deletion tests/jobs/test_nmt_engine_build_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def test_run(decoy: Decoy) -> None:
env = _TestEnvironment(decoy)
env.job.run()

decoy.verify(env.engine.translate_batch(matchers.Anything()), times=1)
pretranslations = json.loads(env.target_pretranslations)
assert len(pretranslations) == 1
assert pretranslations[0]["translation"] == "Please, I have booked a room."
Expand Down