Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages for #62 #63

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Better error messages for #62 #63

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aad2600
Better error messages for #62
johnml1135 Nov 20, 2023
7f7d8e9
Linting error
johnml1135 Nov 20, 2023
cf60661
Update from reviewer comments
johnml1135 Nov 21, 2023
2143397
Reviewer comments - fix bug
johnml1135 Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions machine/translation/huggingface/hugging_face_nmt_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ def __init__(
and src_lang not in cast(Any, self._tokenizer).lang_code_to_id
and src_lang not in additional_special_tokens
):
raise ValueError(f"'{src_lang}' is not a valid language code.")
raise ValueError(f"The specified model does not support the language code '{src_lang}'")

if (
tgt_lang is not None
and tgt_lang not in cast(Any, self._tokenizer).lang_code_to_id
and tgt_lang not in additional_special_tokens
):
raise ValueError(f"'{tgt_lang}' is not a valid language code.")
raise ValueError(f"The specified model does not support the language code '{src_lang}'")

self._pipeline = _TranslationPipeline(
model=model,
Expand Down